Reviewer's Guide

The pull request enhances the extractFiles logic in libzipplugin.cpp by inserting explicit checks for an incorrect password entry and returning a dedicated error (PFT_Error) with a corresponding message, instead of falling through to the generic password-prompt flow.

Sequence diagram for error handling when wrong password is entered during ZIP extraction

sequenceDiagram
    participant User
    participant LibzipPlugin
    participant Archive
    User->>LibzipPlugin: Request to extract encrypted ZIP
    LibzipPlugin->>Archive: Attempt extraction with password
    Archive-->>LibzipPlugin: Return ET_WrongPassword error
    alt Password is not empty
        LibzipPlugin->>User: Show error "Wrong password, extraction failed."
        LibzipPlugin->>Archive: Close archive
        LibzipPlugin->>User: Extraction fails (PFT_Error)
    else Password is empty or other error
        LibzipPlugin->>User: Prompt for password
    end

Class diagram for updated error handling in LibzipPlugin

classDiagram
    class LibzipPlugin {
        - m_eErrorType
        - m_strPassword
        extractFiles(files: QList<FileEntry>, password: QString): PluginFinishType
    }
    LibzipPlugin : extractFiles() checks for ET_WrongPassword
    LibzipPlugin : On wrong password, clears m_strPassword, closes archive, returns PFT_Error
    LibzipPlugin : Emits error("Wrong password.") if password is incorrect

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment